Summary: | [css-flexbox] flex-basis not animatable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jon.ronnenberg | ||||||
Component: | CSS | Assignee: | Sergio Villar Senin <svillar> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | avetis.k, benjamin.devine, bradbice, brkjrdn, clopez, darin, dino, graouts, graouts, jonlee, kyle.bavender, m.goleb+bugzilla, michael, m.kurz+webkitbugs, philip, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | GoodFirstBug, InRadar, WebExposed | ||||||
Version: | Safari 11 | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.11 | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=209872 https://bugs.webkit.org/show_bug.cgi?id=209874 https://bugs.webkit.org/show_bug.cgi?id=209876 |
||||||||
Attachments: |
|
Description
jon.ronnenberg
2017-12-05 11:35:18 PST
Correct link to standard specification: https://www.w3.org/TR/css-flexbox-1/#flex-basis-property Probably needs some new code in CSSPropertyAnimation This can still be reproduced as of MacOS Safari 13.0.3, it would be great to see it fixed It doesn’t fire the ontransitionend event either. It doesn’t even know it’s supposed to transition? (In reply to Ben Devine from comment #3) > This can still be reproduced as of MacOS Safari 13.0.3, it would be great to > see it fixed I confirm. OS: 10.15.3 (19D76) Safari: 13.0.5 (15608.5.11) Safari Preview: Release 102 (Safari 13.2, WebKit 15610.1.5.2) This its tested by WPT tests: css/css-flexbox/animation/flex-basis-composition.html and css/css-flexbox/animation/flex-basis-interpolation.html It appears flex-basis can be transitioned if the transition property set is "all" instead of "flex-basis" or even "flex" and the duration is specified in milliseconds instead of seconds. What property "all" is catching is a mystery. The above comment is true, however this leads to potential performance problems when flex-basis is all that needs to be transitioned. Created attachment 411750 [details]
Patch
Created attachment 411846 [details]
Patch
r=me assuming EWS results are all green. Committed r268792: <https://trac.webkit.org/changeset/268792> I wonder if there's more that needs fixing here, as I see some of the tests are still failing in STP 119: https://wpt.fyi/results/css/css-flexbox/animation/flex-basis-composition.html?run_id=5756059782217728&run_id=5710069272412160&run_id=4895145164013568&run_id=5677840106258432 https://wpt.fyi/results/css/css-flexbox/animation/flex-basis-interpolation.html?run_id=5756059782217728&run_id=5710069272412160&run_id=4895145164013568&run_id=5677840106258432 (In reply to Philip Jägenstedt from comment #14) > I wonder if there's more that needs fixing here, as I see some of the tests > are still failing in STP 119: > https://wpt.fyi/results/css/css-flexbox/animation/flex-basis-composition. > html?run_id=5756059782217728&run_id=5710069272412160&run_id=4895145164013568& > run_id=5677840106258432 > https://wpt.fyi/results/css/css-flexbox/animation/flex-basis-interpolation. > html?run_id=5756059782217728&run_id=5710069272412160&run_id=4895145164013568& > run_id=5677840106258432 Yeah, basically animation composition is still not supported in WebKit AFAIK, Antoine? (In reply to Sergio Villar Senin from comment #15) > (In reply to Philip Jägenstedt from comment #14) > > I wonder if there's more that needs fixing here, as I see some of the tests > > are still failing in STP 119: > > https://wpt.fyi/results/css/css-flexbox/animation/flex-basis-composition. > > html?run_id=5756059782217728&run_id=5710069272412160&run_id=4895145164013568& > > run_id=5677840106258432 > > https://wpt.fyi/results/css/css-flexbox/animation/flex-basis-interpolation. > > html?run_id=5756059782217728&run_id=5710069272412160&run_id=4895145164013568& > > run_id=5677840106258432 > > Yeah, basically animation composition is still not supported in WebKit > AFAIK, Antoine? Correct. The issues in those tests aren't specific to this property but are systemic. I hope to address them but won't be able to for a while still. I see, so those remaining test failures should be ascribed to bug 189299 then I assume. |