Bug 180426

Summary: [GTK] WebDriver: run-webdriver-tests is leaking a DumpRenderTree directory in tmp
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, bugs-noreply, ews-watchlist, glenn, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-12-05 08:40:27 PST
This happens when running the tests with Xvfb driver, because _setup_environ_for_test() is called twice and the DTR is created there every time. Only the last directory created is cleaned up by the driver destructor. The DRT temp directory is only needed for layout tests, so we could even avoid its creation by moving it to the start() method like other drivers do (included the base driver implementation). Since API and WebDriver tests don't call start(), the directory is not even created, and the required env vars are not set either in that case.
Attachments
Patch (14.41 KB, patch)
2017-12-05 08:46 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-12-05 08:46:32 PST
Created attachment 328454 [details] Patch
Carlos Garcia Campos
Comment 2 2017-12-11 00:31:48 PST
Committed r225740: <https://trac.webkit.org/changeset/225740>
Radar WebKit Bug Importer
Comment 3 2017-12-11 00:32:24 PST
<rdar://problem/35962796>
Note You need to log in before you can comment on or make changes to this bug.