Bug 180425

Summary: IsoAlignedMemoryAllocator needs to free all of its memory when the VM destructs
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179288
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2017-12-05 08:38:32 PST
...
Attachments
the patch (1.82 KB, patch)
2017-12-05 13:32 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-12-05 08:55:42 PST
Otherwise we will have leaks due to iso-allocated MarkedBlocks from workers, like here: https://build.webkit.org/LeaksViewer/?url=%2Fresults%2FApple%20High%20Sierra%20%28Leaks%29%2Fr225314%20%281178%29%2F
Filip Pizlo
Comment 2 2017-12-05 13:32:03 PST
Created attachment 328491 [details] the patch
Saam Barati
Comment 3 2017-12-05 13:36:14 PST
Comment on attachment 328491 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=328491&action=review > Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp:64 > + if (!result) > + return nullptr; Lets make the above "tryFastAlignedMalloc"
Filip Pizlo
Comment 4 2017-12-05 13:45:52 PST
Comment on attachment 328491 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=328491&action=review > Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp:41 > + free(block); Also, I should call fastFree here.
Filip Pizlo
Comment 5 2017-12-05 13:55:26 PST
Landed in https://trac.webkit.org/changeset/225540/webkit
Radar WebKit Bug Importer
Comment 6 2017-12-05 13:56:21 PST
<rdar://problem/35863996>
Note You need to log in before you can comment on or make changes to this bug.