WebDriver: several tests in imported/w3c/webdriver/tests/state/get_element_attribute.py are failing

• Component: WebDriver
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

WebDriverTests/imported/w3c/webdriver/tests/state/get_element_attribute.py::test_boolean_attribute[button-attrs1] FAILED
WebDriverTests/imported/w3c/webdriver/tests/state/get_element_attribute.py::test_boolean_attribute[dialog-attrs3] FAILED
WebDriverTests/imported/w3c/webdriver/tests/state/get_element_attribute.py::test_boolean_attribute[form-attrs5] FAILED
WebDriverTests/imported/w3c/webdriver/tests/state/get_element_attribute.py::test_boolean_attribute[iframe-attrs6] FAILED
WebDriverTests/imported/w3c/webdriver/tests/state/get_element_attribute.py::test_boolean_attribute[img-attrs7] FAILED
WebDriverTests/imported/w3c/webdriver/tests/state/get_element_attribute.py::test_boolean_attribute[input-attrs8] FAILED
WebDriverTests/imported/w3c/webdriver/tests/state/get_element_attribute.py::test_boolean_attribute[menuitem-attrs9] FAILED
WebDriverTests/imported/w3c/webdriver/tests/state/get_element_attribute.py::test_boolean_attribute[object-attrs10] FAILED
WebDriverTests/imported/w3c/webdriver/tests/state/get_element_attribute.py::test_global_boolean_attributes FAILED

session = <webdriver.client.Session object at 0x7fa64e79ecd0>, tag = 'dialog', attrs = ['open']

    @pytest.mark.parametrize("tag,attrs", [
        ("audio", ["autoplay", "controls", "loop", "muted"]),
        ("button", ["autofocus", "disabled", "formnovalidate"]),
        ("details", ["open"]),
        ("dialog", ["open"]),
        ("fieldset", ["disabled"]),
        ("form", ["novalidate"]),
        ("iframe", ["allowfullscreen"]),
        ("img", ["ismap"]),
        ("input", ["autofocus", "checked", "disabled", "formnovalidate", "multiple", "readonly", "required"]),
        ("menuitem", ["checked", "default", "disabled"]),
        ("object", ["typemustmatch"]),
        ("ol", ["reversed"]),
        ("optgroup", ["disabled"]),
        ("option", ["disabled", "selected"]),
        ("script", ["async", "defer"]),
        ("select", ["autofocus", "disabled", "multiple", "required"]),
        ("textarea", ["autofocus", "disabled", "readonly", "required"]),
        ("track", ["default"]),
        ("video", ["autoplay", "controls", "loop", "muted"])
    ])
    def test_boolean_attribute(session, tag, attrs):
        # 13.2 Step 5
        for attr in attrs:
            session.url = inline("<{0} {1}>".format(tag, attr))
    
            element = session.find.css(tag, all=False)
            result = result = get_attribute(session, element.id, attr)
>           assert_success(result, "true")

attr       = 'open'
attrs      = ['open']
element    = <webdriver.client.Element object at 0x7fa64e762d50>
result     = <Responsetatus=200 body={"value": ""}>
session    = <webdriver.client.Session object at 0x7fa64e79ecd0>
tag        = 'dialog'

It seems we return an empty string instead of true/false in some cases

[Carlos Garcia Campos]

Created attachment 384499 [details]
Patch

[BJ Burg]

Comment on attachment 384499 [details]
Patch

r=me

[Carlos Garcia Campos]

Committed r254117: <https://trac.webkit.org/changeset/254117>

[Radar WebKit Bug Importer]

<rdar://problem/58368442>