Bug 180382

Summary: Implement setting of service worker to client in SWServer without going to WebProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, japhet, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 180261    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2017-12-04 15:41:56 PST
Implement setting of service worker to client in SWServer without going to WebProcess
Attachments
Patch (28.20 KB, patch)
2017-12-04 15:56 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (29.11 KB, patch)
2017-12-04 16:35 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (28.99 KB, patch)
2017-12-04 20:32 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (29.11 KB, patch)
2017-12-05 10:21 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-12-04 15:56:17 PST
Created attachment 328400 [details] Patch
youenn fablet
Comment 2 2017-12-04 16:35:50 PST
Created attachment 328408 [details] Patch
youenn fablet
Comment 3 2017-12-04 20:32:56 PST
Created attachment 328433 [details] Patch
Chris Dumez
Comment 4 2017-12-05 09:06:20 PST
Comment on attachment 328433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328433&action=review r=me with minor comments. > Source/WebCore/workers/service/server/SWServer.cpp:587 > +SWServerRegistration* SWServer::registrationFromServiceWorkerIdentifier(ServiceWorkerIdentifier identifier) It would be good if we had a registration() getter on the SWServerWorker class instead. It would be more reusable this way. > Source/WebCore/workers/service/server/SWServer.h:148 > + WEBCORE_EXPORT void registerServiceWorkerClient(ClientOrigin&&, ServiceWorkerClientIdentifier, ServiceWorkerClientData&&, const std::optional<ServiceWorkerIdentifier>&); I think we should provide the name for the last parameter as it is non-obvious to me.
youenn fablet
Comment 5 2017-12-05 10:20:14 PST
> > Source/WebCore/workers/service/server/SWServer.cpp:587 > > +SWServerRegistration* SWServer::registrationFromServiceWorkerIdentifier(ServiceWorkerIdentifier identifier) > > It would be good if we had a registration() getter on the SWServerWorker > class instead. It would be more reusable this way. Agreed, let's see how we can do that in future refactoring. > > Source/WebCore/workers/service/server/SWServer.h:148 > > + WEBCORE_EXPORT void registerServiceWorkerClient(ClientOrigin&&, ServiceWorkerClientIdentifier, ServiceWorkerClientData&&, const std::optional<ServiceWorkerIdentifier>&); > > I think we should provide the name for the last parameter as it is > non-obvious to me. OK
youenn fablet
Comment 6 2017-12-05 10:21:46 PST
Created attachment 328463 [details] Patch
WebKit Commit Bot
Comment 7 2017-12-05 10:42:09 PST
Comment on attachment 328463 [details] Patch Clearing flags on attachment: 328463 Committed r225526: <https://trac.webkit.org/changeset/225526>
WebKit Commit Bot
Comment 8 2017-12-05 10:42:10 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-12-05 10:45:27 PST
<rdar://problem/35858689>
Note You need to log in before you can comment on or make changes to this bug.