Bug 180381 – Alternative Presentation Button: No need to unapply shadow DOM substitution when removed by page

• Component: WebCore Misc.
• Status: RESOLVED INVALID

[Daniel Bates]

Currently we unapply the alternative presentation button substitution whenever the associated Alternative Presentation Button is removed. We should only unapply the substitution when the Alternative Presentation Button is removed via SPI. Otherwise, we will cause the assertion NoEventDispatchAssertion::InMainThread::isEventDispatchAllowedInSubtree(child) to fail in WebCore::dispatchChildRemovalEvents() when unapplying the substitution for an <input> (since unapplying the substitution for an <input> changes its input type => destroys and creates a new shadow subtree).

[Radar WebKit Bug Importer]

<rdar://problem/35841099>

[Daniel Bates]

Created attachment 328401 [details]
Patch and layout test

[Brent Fulgham]

Comment on attachment 328401 [details]
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=328401&action=review

> Source/WebCore/editing/cocoa/AlternativePresentationButtonSubstitution.h:47
> +    void unapply(bool fromAPI);

This would be better with an enum, but I'm fine with this as-is.

[Daniel Bates]

The approach for the alternative presentation button has since changed. This bug is no longer applicable.