Bug 180358 – <video> and scale() transforms yield shrunk small or clipped controls

• Component: Media
• Status: RESOLVED FIXED

[Antoine Quint]

If a <video> element is transformed, directly or through a parent, with a scale() command, its controls will appear clipped, when scale > 1, or shrunk, when scale < 0.

[Antoine Quint]

<rdar://problem/34436124>

[Antoine Quint]

Created attachment 328349 [details]
Patch

[Dean Jackson]

Comment on attachment 328349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328349&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:226
> +        while (node && node instanceof HTMLElement) {
> +            transform = transform.multiply(new WebKitCSSMatrix(getComputedStyle(node).transform));
> +            node = node.parentNode;

What happens if any of these transforms change after the calculation?

[Antoine Quint]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 328349 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328349&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:226
> > +        while (node && node instanceof HTMLElement) {
> > +            transform = transform.multiply(new WebKitCSSMatrix(getComputedStyle(node).transform));
> > +            node = node.parentNode;
> 
> What happens if any of these transforms change after the calculation?

Nothing, it doesn't change the metrics of the elements.

[WebKit Commit Bot]

Comment on attachment 328349 [details]
Patch

Clearing flags on attachment: 328349

Committed r225495: <https://trac.webkit.org/changeset/225495>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

Comment on attachment 328349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328349&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:225
> +            transform = transform.multiply(new WebKitCSSMatrix(getComputedStyle(node).transform));

Why not DOMMatrix? WebKitCSSMatrix should go away eventually.

[Antoine Quint]

Committed r225521: <https://trac.webkit.org/changeset/225521>

[Antoine Quint]

(In reply to Simon Fraser (smfr) from comment #7)
> Comment on attachment 328349 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328349&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:225
> > +            transform = transform.multiply(new WebKitCSSMatrix(getComputedStyle(node).transform));
> 
> Why not DOMMatrix? WebKitCSSMatrix should go away eventually.

This was fixed in a follow-up commit (r225521).