Summary: | WebDriver: evaluateJavaScriptFunction should return null when return value is undefined | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, clopez, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-12-04 04:21:12 PST
Created attachment 328341 [details]
Patch
Brian, could you check if this affects safari driver? Maybe you need to adapt the driver implementation, like I did. Comment on attachment 328341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328341&action=review This does not seem to regress any safaridriver tests, feel free to land as you please. > Source/WebDriver/ChangeLog:8 > + Stop handling the empty string a as a special case of evaluateJavaScriptFunction result. Nit: 'a as a' (In reply to Brian Burg from comment #3) > Comment on attachment 328341 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328341&action=review > > This does not seem to regress any safaridriver tests, feel free to land as > you please. Cool, thanks! > > Source/WebDriver/ChangeLog:8 > > + Stop handling the empty string a as a special case of evaluateJavaScriptFunction result. > > Nit: 'a as a' Committed r227773: <https://trac.webkit.org/changeset/227773> |