Bug 180304

Summary: WorkerCacheStorageConnection should handle the case of terminated workers
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, cdumez, commit-queue, darin, ggaren, jlewis3, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2017-12-01 18:27:34 PST
WorkerCacheStorageConnection should handle the case of terminated workers
Attachments
Patch (18.59 KB, patch)
2017-12-01 18:31 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (16.39 KB, patch)
2017-12-04 09:34 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-12-01 18:31:34 PST
Created attachment 328203 [details] Patch
Darin Adler
Comment 2 2017-12-02 18:53:58 PST
Comment on attachment 328203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328203&action=review > Source/WebCore/ChangeLog:14 > + Added a method to check a worker thread is still valid. That type of technique won’t work 100% perfectly. It’s possible that the thread has been fully deleted, but then a new thread allocated, and the new one is in the same memory so happens to have the same address.
youenn fablet
Comment 3 2017-12-02 18:57:44 PST
Comment on attachment 328203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328203&action=review >> Source/WebCore/ChangeLog:14 >> + Added a method to check a worker thread is still valid. > > That type of technique won’t work 100% perfectly. It’s possible that the thread has been fully deleted, but then a new thread allocated, and the new one is in the same memory so happens to have the same address. I guess I could further check the thread id if the pointer is still alive.
youenn fablet
Comment 4 2017-12-04 09:34:57 PST
Created attachment 328352 [details] Patch
Chris Dumez
Comment 5 2017-12-04 09:47:46 PST
Patch appears to fix the crash for me locally.
Chris Dumez
Comment 6 2017-12-04 10:13:50 PST
Comment on attachment 328352 [details] Patch Clearing flags on attachment: 328352 Committed r225481: <https://trac.webkit.org/changeset/225481>
Chris Dumez
Comment 7 2017-12-04 10:13:52 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 8 2017-12-04 10:14:07 PST
*** Bug 180337 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
Comment 9 2017-12-04 10:14:22 PST
<rdar://problem/35831955>
Note You need to log in before you can comment on or make changes to this bug.