Bug 180298

Summary: Factor out the "databaseTaskQueue" parts of IDBServer into something reusable
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Web Template FrameworkAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP to send home with me
none
Patch
none
Patch
none
Patch none

Brady Eidson
Reported 2017-12-01 17:08:35 PST
Factor out the "databaseTaskQueue" parts of IDBServer into something reusable I'll be using them in SW-land soon.
Attachments
WIP to send home with me (13.67 KB, patch)
2017-12-01 17:12 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (17.06 KB, patch)
2017-12-01 21:02 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (17.76 KB, patch)
2017-12-01 21:38 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (17.71 KB, patch)
2017-12-01 22:51 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-12-01 17:12:36 PST
Created attachment 328189 [details] WIP to send home with me WIP to send home with me
Brady Eidson
Comment 2 2017-12-01 21:02:31 PST
Created attachment 328207 [details] Patch
Brady Eidson
Comment 3 2017-12-01 21:38:29 PST
Created attachment 328211 [details] Patch
Brady Eidson
Comment 4 2017-12-01 22:44:07 PST
Caused very real crashes (asserts?) in WK1 IDB tests, so clearly not ready for review.
Brady Eidson
Comment 5 2017-12-01 22:51:17 PST
Created attachment 328215 [details] Patch
Chris Dumez
Comment 6 2017-12-02 09:39:49 PST
Comment on attachment 328215 [details] Patch r=me
WebKit Commit Bot
Comment 7 2017-12-02 10:00:22 PST
Comment on attachment 328215 [details] Patch Clearing flags on attachment: 328215 Committed r225450: <https://trac.webkit.org/changeset/225450>
WebKit Commit Bot
Comment 8 2017-12-02 10:00:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-12-02 10:01:41 PST
<rdar://problem/35815097>
Daniel Bates
Comment 10 2017-12-02 11:17:46 PST
Comment on attachment 328215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328215&action=review > Source/WTF/wtf/CrossThreadTaskHandler.h:52 > + RefPtr<Thread> m_thread { nullptr }; It is unnecessary to initialize this ivar to nullptr as t default constructs to it. Moreover, the constructor explicitly initializes this ivar.
Brady Eidson
Comment 11 2017-12-02 16:07:04 PST
(In reply to Daniel Bates from comment #10) > Comment on attachment 328215 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328215&action=review > > > Source/WTF/wtf/CrossThreadTaskHandler.h:52 > > + RefPtr<Thread> m_thread { nullptr }; > > It is unnecessary to initialize this ivar to nullptr as t default constructs > to it. Moreover, the constructor explicitly initializes this ivar. Sure, but it's not a surprise after things go through refactors and straight moves (like this one) that some history is lost. e.g., Originally a raw Thread*? :) No harm in this - Should be optimized out. Sounds like an opportunity for style-bot, though.
Note You need to log in before you can comment on or make changes to this bug.