Bug 180256

Summary: [GStreamer] Fix USE_GSTREAMER_GL check for GStreamer 1.10
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez, commit-queue, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-12-01 09:56:08 PST
It's not safe to change the value of build options after WEBKIT_OPTION_END, since it breaks the option dependency checker. I don't think that actually hurts anything in this case, but let's not encourage bad practice. Also, it's not good for features to be silently disabled. Failing the build at the CMake stage lets distributors know that a feature will be missing. And of course, it's still possible to disable USE_GSTREAMER_GL to avoid the increased GStreamer requirement.
Attachments
Patch (1.88 KB, patch)
2017-12-01 10:00 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-12-01 10:00:10 PST
Created attachment 328110 [details] Patch
WebKit Commit Bot
Comment 2 2017-12-01 10:39:18 PST
Comment on attachment 328110 [details] Patch Clearing flags on attachment: 328110 Committed r225401: <https://trac.webkit.org/changeset/225401>
WebKit Commit Bot
Comment 3 2017-12-01 10:39:19 PST
All reviewed patches have been landed. Closing bug.
Carlos Alberto Lopez Perez
Comment 4 2017-12-01 10:56:04 PST
This broke both Debian and Ubuntu GTK bots. I fixed that locally by passing --cmakeargs=-DUSE_GSTREAMER_GL=OFF
Note You need to log in before you can comment on or make changes to this bug.