Bug 180209

Summary:

Update RGB/RGBA parsing to match CSS Color 4

Product:

WebKit

Reporter:

Chris Nardi <cnardi>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

achristensen, dino, ews-watchlist, m_dubet, rniwa, sam, sebastianzartner, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews114 for mac-sierra	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Update tests	none

Chris Nardi

Reported 2017-11-30 11:29:39 PST

In CSS Color 4, there have been several changes to the grammar of the RGB/RGBA functions. See https://drafts.csswg.org/css-color/#rgb-functions. WebKit does not appear to have implemented any of the changes (e.g. percent alpha values, comma-less syntax, and making the two functions synonyms). As a result, Safari is failing all of the RGB/RGBA tests at https://wpt.fyi/css/css-color.

Attachments
Patch (7.27 KB, patch) 2018-05-21 14:48 PDT, Chris Nardi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.92 MB, application/zip) 2018-05-21 16:00 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.85 MB, application/zip) 2018-05-21 16:10 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (3.47 MB, application/zip) 2018-05-21 16:37 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (3.24 MB, application/zip) 2018-05-21 16:38 PDT, EWS Watchlist	no flags	Details
Update tests (100.59 KB, patch) 2018-05-21 16:52 PDT, Chris Nardi	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Nardi

Comment 1 2018-05-21 14:48:46 PDT

Created attachment 340897 [details] Patch

EWS Watchlist

Comment 2 2018-05-21 16:00:31 PDT

Comment on attachment 340897 [details] Patch Attachment 340897 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7757962 New failing tests: imported/w3c/web-platform-tests/css/css-color/rgb-006.html imported/w3c/web-platform-tests/css/css-color/rgba-002.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html fast/canvas/gradient-addColorStop-with-invalid-color.html imported/w3c/web-platform-tests/css/css-color/rgb-004.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/web-platform-tests/css/css-color/rgba-008.html fast/css/rgb-float.html imported/w3c/web-platform-tests/css/css-color/rgb-002.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/web-platform-tests/css/css-color/rgba-006.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html imported/w3c/web-platform-tests/css/css-color/rgba-004.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/web-platform-tests/css/css-color/rgb-008.html

EWS Watchlist

Comment 3 2018-05-21 16:00:32 PDT

Created attachment 340914 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-05-21 16:10:31 PDT

Comment on attachment 340897 [details] Patch Attachment 340897 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7757995 New failing tests: imported/w3c/web-platform-tests/css/css-color/rgb-006.html imported/w3c/web-platform-tests/css/css-color/rgba-002.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html fast/canvas/gradient-addColorStop-with-invalid-color.html imported/w3c/web-platform-tests/css/css-color/rgb-004.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/web-platform-tests/css/css-color/rgba-008.html fast/css/rgb-float.html imported/w3c/web-platform-tests/css/css-color/rgb-002.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/web-platform-tests/css/css-color/rgba-006.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html imported/w3c/web-platform-tests/css/css-color/rgba-004.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/web-platform-tests/css/css-color/rgb-008.html

EWS Watchlist

Comment 5 2018-05-21 16:10:33 PDT

Created attachment 340917 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-05-21 16:37:07 PDT

Comment on attachment 340897 [details] Patch Attachment 340897 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7758175 New failing tests: imported/w3c/web-platform-tests/css/css-color/rgb-006.html imported/w3c/web-platform-tests/css/css-color/rgba-002.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html fast/canvas/gradient-addColorStop-with-invalid-color.html imported/w3c/web-platform-tests/css/css-color/rgb-004.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/web-platform-tests/css/css-color/rgba-008.html fast/css/rgb-float.html imported/w3c/web-platform-tests/css/css-color/rgb-002.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/web-platform-tests/css/css-color/rgba-006.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html imported/w3c/web-platform-tests/css/css-color/rgba-004.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/web-platform-tests/css/css-color/rgb-008.html

EWS Watchlist

Comment 7 2018-05-21 16:37:09 PDT

Created attachment 340922 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-05-21 16:38:32 PDT

Comment on attachment 340897 [details] Patch Attachment 340897 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7758062 New failing tests: imported/w3c/web-platform-tests/css/css-color/rgb-006.html imported/w3c/web-platform-tests/css/css-color/rgba-002.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html fast/canvas/gradient-addColorStop-with-invalid-color.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/web-platform-tests/css/css-color/rgba-008.html fast/css/rgb-float.html imported/w3c/web-platform-tests/css/css-color/rgb-002.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/web-platform-tests/css/css-color/rgb-004.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/web-platform-tests/css/css-color/rgba-006.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html imported/w3c/web-platform-tests/css/css-color/rgba-004.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/web-platform-tests/css/css-color/rgb-008.html

EWS Watchlist

Comment 9 2018-05-21 16:38:33 PDT

Created attachment 340923 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Chris Nardi

Comment 10 2018-05-21 16:52:26 PDT

Created attachment 340926 [details] Update tests

Chris Nardi

Comment 11 2018-06-12 09:47:49 PDT

Simon: have you had a chance to take a look at this patch?

Alex Christensen

Comment 12 2021-11-01 12:15:37 PDT

Comment on attachment 340926 [details] Update tests This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.

Matthieu Dubet

Comment 13 2024-02-06 14:18:41 PST

I think we support the CSS Color 4 changes for rgb/rgba. Feel free to open a specific bug if there are still parts of our implementation missing and/or buggy.

Note You need to log in before you can comment on or make changes to this bug.