Bug 180187

Summary: WebDriver: locator strategy should be validated before trying to find elements
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, clopez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch clopez: review+

Carlos Garcia Campos
Reported 2017-11-30 03:17:24 PST
We currently rely on the js atom to raise an exception in case the locator strategy is not valid, but in case of find element from element, if the element doesn't exist we fail with stale element error instead of invalid argument as expected. So, let's validate the strategies when parsing them, which would also avoid going to the browser in cae of invalid strategy.
Attachments
Patch (2.34 KB, patch)
2017-11-30 03:19 PST, Carlos Garcia Campos 		clopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-11-30 03:19:20 PST
Created attachment 327964 [details] Patch
Carlos Garcia Campos
Comment 2 2017-11-30 05:48:56 PST
Committed r225326: <https://trac.webkit.org/changeset/225326>
Radar WebKit Bug Importer
Comment 3 2017-11-30 05:50:26 PST
<rdar://problem/35771142>
Note You need to log in before you can comment on or make changes to this bug.