Bug 18010

Summary: WebKitNetworkRequestPrivate is defined in two places unnecessarily
Product: WebKit Reporter: Jasper Bryant-Greene <jasper>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jmalonzo
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
remove duplicate definition of WebKitNetworkRequest
none
updated patch removes dupe definition from webkitprivate.h rather than from webkitnetworkrequest.cpp darin: review+

Jasper Bryant-Greene
Reported 2008-03-22 02:10:08 PDT
WebKitNetworkRequestPrivate is defined in both WebKit/gtk/webkit/webkitnetworkrequest.cpp and in WebKit/gtk/webkit/webkitprivate.h. This is unnecessary code duplication as far as I can tell. Alternatively, if there is a reason for it then maybe some comments should be added? Patch momentarily.
Attachments
remove duplicate definition of WebKitNetworkRequest (1.42 KB, patch)
2008-03-22 02:11 PDT, Jasper Bryant-Greene
no flags
updated patch removes dupe definition from webkitprivate.h rather than from webkitnetworkrequest.cpp (1.62 KB, patch)
2008-03-22 02:56 PDT, Jasper Bryant-Greene
darin: review+
Jasper Bryant-Greene
Comment 1 2008-03-22 02:11:35 PDT
Created attachment 19963 [details] remove duplicate definition of WebKitNetworkRequest
Jan Alonzo
Comment 2 2008-03-22 02:33:44 PDT
hi Jasper I think you should move the struct and the _GET_PRIVATE macro out of webkitprivate.h and into webkitnetworkrequest.cpp. I think the frame and view structs just there because they need each other. Regards
Jasper Bryant-Greene
Comment 3 2008-03-22 02:37:54 PDT
Hmm, you're right. I'm not sure what WebKitNetworkRequestPrivate is doing in webkitprivate.h at all, then. I initially assumed there must be a reason but a grep would indicate not. I'll move it into webkitnetworkrequest.cpp and build-test, and if that's OK, I'll submit a patch shortly.
Jasper Bryant-Greene
Comment 4 2008-03-22 02:56:17 PDT
Created attachment 19969 [details] updated patch removes dupe definition from webkitprivate.h rather than from webkitnetworkrequest.cpp
Darin Adler
Comment 5 2008-03-26 10:09:27 PDT
Comment on attachment 19969 [details] updated patch removes dupe definition from webkitprivate.h rather than from webkitnetworkrequest.cpp r=me
Julien Chaffraix
Comment 6 2008-03-31 14:42:50 PDT
Committed in r31480.
Note You need to log in before you can comment on or make changes to this bug.