Bug 180070

Summary: [JSC] Add MacroAssembler::getEffectiveAddress in all platforms
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yusuke Suzuki
Reported 2017-11-28 00:38:40 PST
[JSC] Add MacroAssembler::getEffectiveAddress in all platforms
Attachments
Patch (10.87 KB, patch)
2017-11-28 00:40 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (10.92 KB, patch)
2017-11-28 00:54 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-11-28 00:40:25 PST
Created attachment 327734 [details] Patch
Yusuke Suzuki
Comment 2 2017-11-28 00:54:53 PST
Created attachment 327736 [details] Patch
Saam Barati
Comment 3 2017-11-29 09:12:22 PST
Comment on attachment 327736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327736&action=review > Source/JavaScriptCore/yarr/YarrJIT.cpp:361 > + notUnicode.append(branchPtr(AboveOrEqual, regUnicodeInputAndTrail, regUnicodeTemp)); Is it possible to add a test for this?
Yusuke Suzuki
Comment 4 2017-11-29 09:17:39 PST
Comment on attachment 327736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327736&action=review Thanks >> Source/JavaScriptCore/yarr/YarrJIT.cpp:361 >> + notUnicode.append(branchPtr(AboveOrEqual, regUnicodeInputAndTrail, regUnicodeTemp)); > > Is it possible to add a test for this? I think this is a bit difficult since it depends on string ptr's lower 32bit. If +2 is accidentally overflowed, original 32bit comparison becomes incorrect.
WebKit Commit Bot
Comment 5 2017-11-29 09:37:40 PST
Comment on attachment 327736 [details] Patch Clearing flags on attachment: 327736 Committed r225271: <https://trac.webkit.org/changeset/225271>
WebKit Commit Bot
Comment 6 2017-11-29 09:37:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-29 09:39:57 PST
<rdar://problem/35749735>
Note You need to log in before you can comment on or make changes to this bug.