REGRESSION (r225199): webkitpy: PlatformInfo raises AssertionError "assert self.os_version is not None" in Cygwin since Bug 179621

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Fujii Hironori]

>  $ ./Tools/Scripts/check-webkit-style
> Traceback (most recent call last):
>   File "./Tools/Scripts/check-webkit-style", line 44, in <module>
>     from webkitpy.style.main import CheckWebKitStyle
>   File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/main.py", line 27, in <module>
>     import webkitpy.style.checker as checker
>   File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/checker.py", line 54, in <module>
>     from checkers.test_expectations import TestExpectationsChecker
>   File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 46, in <module>
>     class TestExpectationsChecker(object):
>   File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 124, in TestExpectationsChecker
>     def lint_test_expectations(files, configuration, cwd, increment_error_count=lambda: 0, line_numbers=None, host=Host()):
>   File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/host.py", line 48, in __init__
>     SystemHost.__init__(self)
>   File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/system/systemhost.py", line 40, in __init__
>     self.user = user.User()
>   File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/system/user.py", line 61, in __init__
>     self._platforminfo = platforminfo or PlatformInfo(sys, platform, Executive())
>   File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/system/platforminfo.py", line 74, in __init__
>     assert self.os_version is not None
> AssertionError
>

[Fujii Hironori]

The output of ver command looks like this:

> C:\>ver
> 
> Microsoft Windows [Version 10.0.16299.64]
>

[Fujii Hironori]

Created attachment 327735 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 327735 [details]
Patch

Clearing flags on attachment: 327735

Committed r225215: <https://trac.webkit.org/changeset/225215>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35721810>