Bug 180057

Summary: Spread can escape when CreateRest does not
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
jfbastien: review+
patch for landing none

Saam Barati
Reported 2017-11-27 14:57:50 PST
Previously, we didn't handle this IR because I didn't think it was possible to generate. It turns out it is possible, and it happens when we PutStack the Spread but nothing escapes the CreateRest. It's easy to support this, so we will. Patch forthcoming.
Attachments
patch (11.47 KB, patch)
2017-11-27 15:09 PST, Saam Barati 		jfbastien: review+
DetailsFormatted DiffDiff
patch for landing (11.49 KB, patch)
2017-11-27 15:41 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-11-27 15:08:34 PST
<rdar://problem/35676119>
Saam Barati
Comment 2 2017-11-27 15:09:12 PST
Created attachment 327692 [details] patch
JF Bastien
Comment 3 2017-11-27 15:31:20 PST
Comment on attachment 327692 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=327692&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5292 > + static_assert(sizeof(JSValue) == 8 && 1 << 3 == 8, "Assumed in the code below."); 1 << 3 == 8 ? Seems pretty stable :p
Saam Barati
Comment 4 2017-11-27 15:41:48 PST
Created attachment 327701 [details] patch for landing
WebKit Commit Bot
Comment 5 2017-11-27 16:14:11 PST
Comment on attachment 327701 [details] patch for landing Clearing flags on attachment: 327701 Committed r225202: <https://trac.webkit.org/changeset/225202>
WebKit Commit Bot
Comment 6 2017-11-27 16:14:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.