Bug 180050

Summary: Implement OffscreenCanvas.getContext("webgl")
Product: WebKit Reporter: Dean Jackson <dino>
Component: CanvasAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, hi, joepeck, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Dean Jackson
Reported 2017-11-27 13:04:45 PST
Implement OffscreenCanvas.getContext("webgl")
Attachments
Patch (31.26 KB, patch)
2017-11-27 13:18 PST, Dean Jackson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-11-27 13:07:10 PST
<rdar://problem/35705473>
Dean Jackson
Comment 2 2017-11-27 13:18:12 PST
Created attachment 327666 [details] Patch
Sam Weinig
Comment 3 2017-11-27 13:32:17 PST
Comment on attachment 327666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327666&action=review > Source/WebCore/html/OffscreenCanvas.cpp:81 > + if (m_context) > + return { RefPtr<WebGLRenderingContext> { &downcast<WebGLRenderingContext>(*m_context) } }; I think this should only return m_context if contextType == RenderingContextType::Webgl. Otherwise, it should be nullptr.
Dean Jackson
Comment 4 2017-11-27 14:13:07 PST
Committed r225193: <https://trac.webkit.org/changeset/225193>
Note You need to log in before you can comment on or make changes to this bug.