Bug 180044
| Summary: | Re-enable the recursive tail call optimisation for closures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Morisset <rmorisset> |
| Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 179835 | ||
| Bug Blocks: | |||
Robin Morisset
In https://bugs.webkit.org/show_bug.cgi?id=179835 I disabled recursive tail call optimisation on closures because it is wrong in general.
It is possible in theory to re-enable it with the following changes:
- Test that the callee cell itself is the same, and not just its executable.
- This in turns requires storing a pointer to the callee cell in the InlineStackEntry.
- If it is different, we do not want to OSR exit, as it may be a common case, we want to branch to a slow path in which we will compile the tail call in the normal fashion.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Robin Morisset
*** This bug has been marked as a duplicate of bug 184582 ***