Bug 180027

Summary:

Use TextStream's indent tracking, rather than passing indent to all the externalRepresentation() functions

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, jonlee, rniwa, sam, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews113 for mac-elcapitan	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	jonlee: review+

Simon Fraser (smfr)

Reported 2017-11-26 21:09:54 PST

Use TextStream's indent tracking, rather than passing indent to all the externalRepresentation() functions

Attachments
Patch (67.52 KB, patch) 2017-11-26 21:11 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (67.46 KB, patch) 2017-11-26 21:31 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (3.19 MB, application/zip) 2017-11-26 22:29 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (3.53 MB, application/zip) 2017-11-26 22:42 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (3.96 MB, application/zip) 2017-11-26 22:50 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (3.54 MB, application/zip) 2017-11-26 22:56 PST, EWS Watchlist	no flags	Details
Patch (69.85 KB, patch) 2017-11-26 22:57 PST, Simon Fraser (smfr)	jonlee: review+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2017-11-26 21:11:05 PST

Created attachment 327611 [details] Patch

Simon Fraser (smfr)

Comment 2 2017-11-26 21:31:38 PST

Created attachment 327612 [details] Patch

EWS Watchlist

Comment 3 2017-11-26 22:29:20 PST

Comment on attachment 327612 [details] Patch Attachment 327612 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5371083 New failing tests: css3/filters/effect-reference-hw.html svg/custom/feComponentTransfer-Gamma.svg svg/W3C-SVG-1.1/filters-comptran-01-b.svg svg/custom/feComponentTransfer-Discrete.svg svg/custom/feComponentTransfer-Table.svg svg/custom/feComponentTransfer-Linear.svg svg/filters/filter-refresh.svg css3/filters/effect-reference.html

EWS Watchlist

Comment 4 2017-11-26 22:29:22 PST

Created attachment 327614 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 5 2017-11-26 22:42:03 PST

Comment on attachment 327612 [details] Patch Attachment 327612 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5371116 New failing tests: css3/filters/effect-reference-hw.html svg/custom/feComponentTransfer-Gamma.svg svg/W3C-SVG-1.1/filters-comptran-01-b.svg svg/custom/feComponentTransfer-Discrete.svg svg/filters/filter-refresh.svg svg/custom/feComponentTransfer-Linear.svg svg/custom/feComponentTransfer-Table.svg css3/filters/effect-reference.html

EWS Watchlist

Comment 6 2017-11-26 22:42:08 PST

Created attachment 327616 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 7 2017-11-26 22:50:35 PST

Comment on attachment 327612 [details] Patch Attachment 327612 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5371121 New failing tests: css3/filters/effect-reference-hw.html svg/custom/feComponentTransfer-Gamma.svg svg/W3C-SVG-1.1/filters-comptran-01-b.svg svg/custom/feComponentTransfer-Discrete.svg svg/custom/feComponentTransfer-Table.svg svg/custom/feComponentTransfer-Linear.svg svg/filters/filter-refresh.svg css3/filters/effect-reference.html

EWS Watchlist

Comment 8 2017-11-26 22:50:36 PST

Created attachment 327618 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 9 2017-11-26 22:56:05 PST

Comment on attachment 327612 [details] Patch Attachment 327612 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5371129 New failing tests: css3/filters/effect-reference-hw.html svg/custom/feComponentTransfer-Gamma.svg svg/W3C-SVG-1.1/filters-comptran-01-b.svg svg/custom/feComponentTransfer-Discrete.svg svg/filters/filter-refresh.svg css3/filters/effect-reference.html svg/custom/feComponentTransfer-Table.svg svg/custom/feComponentTransfer-Linear.svg

EWS Watchlist

Comment 10 2017-11-26 22:56:06 PST

Created attachment 327619 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 11 2017-11-26 22:57:30 PST

Created attachment 327620 [details] Patch

EWS Watchlist

Comment 12 2017-11-26 23:00:36 PST

Attachment 327620 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/TextStream.h:103: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 13 2017-11-27 07:43:35 PST

A question I have about this is do we want "indent" in the TextStream namespace or not? I was nervous about adding an indent symbol in the WTF namespace.

Simon Fraser (smfr)

Comment 14 2017-11-27 11:17:17 PST

Darin says no namespace.

Simon Fraser (smfr)

Comment 15 2017-11-27 12:02:44 PST

https://trac.webkit.org/r225185

Radar WebKit Bug Importer

Comment 16 2017-12-06 16:46:11 PST

<rdar://problem/35896560>

Note You need to log in before you can comment on or make changes to this bug.