Bug 179988

Summary: Heap::isMarked and friends should be instance methods
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch saam: review+

Filip Pizlo
Reported 2017-11-23 17:09:20 PST
They need to find Heap, so they might as well be given a pointer to it. I bet all callers already have access to VM.
Attachments
Patch (69.39 KB, patch)
2019-03-24 04:07 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-24 04:07:53 PDT
Created attachment 365825 [details] Patch
EWS Watchlist
Comment 2 2019-03-24 04:09:47 PDT
Attachment 365825 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/GCIncomingRefCountedSetInlines.h:43: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 60 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2019-03-25 15:41:13 PDT
Committed r243467: <https://trac.webkit.org/changeset/243467>
Radar WebKit Bug Importer
Comment 4 2019-03-25 15:43:12 PDT
<rdar://problem/49233283>
Note You need to log in before you can comment on or make changes to this bug.