Bug 179976

Summary: [CoordGraphics] UpdateAtlas constructor should receive an IntSize, not a dimension value
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2017-11-23 06:58:10 PST
[CoordGraphics] UpdateAtlas constructor should receive an IntSize, not a dimension value
Attachments
Patch (4.03 KB, patch)
2017-11-23 07:00 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.99 KB, patch)
2017-11-24 03:26 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-11-23 07:00:29 PST
Created attachment 327497 [details] Patch
Carlos Garcia Campos
Comment 2 2017-11-24 01:26:12 PST
Comment on attachment 327497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327497&action=review > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:398 > + static const int s_atlasSize = 1024; > + m_updateAtlases.append(std::make_unique<UpdateAtlas>(*this, IntSize(s_atlasSize, s_atlasSize), flags)); If s_atlasSize is only used here for this, why not static IntSize s_atlasSize = { 1024, 1024 }; ?
Zan Dobersek
Comment 3 2017-11-24 02:30:24 PST
Comment on attachment 327497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327497&action=review >> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:398 >> + m_updateAtlases.append(std::make_unique<UpdateAtlas>(*this, IntSize(s_atlasSize, s_atlasSize), flags)); > > If s_atlasSize is only used here for this, why not static IntSize s_atlasSize = { 1024, 1024 }; ? OK.
Zan Dobersek
Comment 4 2017-11-24 03:26:54 PST
Created attachment 327536 [details] Patch for landing
Zan Dobersek
Comment 5 2017-11-24 03:27:45 PST
Comment on attachment 327536 [details] Patch for landing Clearing flags on attachment: 327536 Committed r225131: <https://trac.webkit.org/changeset/225131>
Zan Dobersek
Comment 6 2017-11-24 03:27:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-24 03:31:13 PST
<rdar://problem/35682158>
Note You need to log in before you can comment on or make changes to this bug.