Summary: | Fast binding generation by batching several files at once | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||||
Component: | Tools / Tests | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, Basuke.Suzuki, cdumez, commit-queue, don.olmstead, ews-watchlist, Hironori.Fujii, lforschler, sam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Basuke Suzuki
2017-11-22 15:27:11 PST
Created attachment 327472 [details]
patch
Created attachment 327708 [details]
fix
I'm ok with this as long as Sam doesn't object. Comment on attachment 327708 [details] fix View in context: https://bugs.webkit.org/attachment.cgi?id=327708&action=review > Source/WebCore/bindings/scripts/generate-bindings-all.pl:167 > + my $batchCount = 30; > + # my $batchCount = int(($totalCount - $currentCount) / $numOfJobs) || 1; Let's not comment out a line. Also, the second line isn't quite right either. As it is it strangely gives smaller batches as work progresses. Let's do something more like $totalCount / $numOfJobs. Created attachment 328537 [details]
fixed
fixed as Alex reviewed.
Comment on attachment 328537 [details] fixed Clearing flags on attachment: 328537 Committed r225565: <https://trac.webkit.org/changeset/225565> All reviewed patches have been landed. Closing bug. |