Bug 179926

Summary: tuple related items are used in WTF without including tuple
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, don.olmstead, ews-watchlist, mjs, webkit-bug-importer, yoshiaki.jitsukawa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add tuple includes to WTF headers. none

Stephan Szabo
Reported 2017-11-21 11:22:48 PST
There are some cases where a few WTF headers that use tuple without including <tuple> (HashFunctions.h, PrintStream.h, Signals.h) can cause compilation failures on toolchains where tuple isn't being already defined (for example via include from another previously included STL header) and don't delay templates like MSVC. For Signals.h, it appears that the only place in Signals.cpp the additional <tuple> include would work in break the header include order (it would have to be before the include of Signals.h itself). For PrintStream.h, it might be possible to find another location, although the first specific error we see is in SlotVisitor.cpp and adding in the accepted header include position in either that file or SlotVisitor.h did not fix the error. For HashFunctions (or at least HashTraits that uses it), there appeared to be failures in WTF, LLIntOffsetsExtractor, and JavaScriptCore and test* apps for failures to find make_tuple via paths including it from heap/Weak.h and text/CString.h across at least 5 of the JSC unified sources.
Attachments
Add tuple includes to WTF headers. (1.62 KB, patch)
2017-11-21 11:30 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2017-11-21 11:30:07 PST
Created attachment 327423 [details] Add tuple includes to WTF headers.
Don Olmstead
Comment 2 2017-11-21 11:49:29 PST
This was brought up at the contributors meeting so hopefully we can land this. STL makes no guarantees that any one header includes another header within the STL so that's one reason we believe that other platforms are not having these problems.
Stephan Szabo
Comment 3 2017-11-21 12:45:18 PST
Adding Alex as he had commented on https://bugs.webkit.org/show_bug.cgi?id=169769
Don Olmstead
Comment 4 2017-11-21 16:16:16 PST
*** Bug 169769 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 5 2017-11-22 09:56:15 PST
Comment on attachment 327423 [details] Add tuple includes to WTF headers. Clearing flags on attachment: 327423 Committed r225096: <https://trac.webkit.org/changeset/225096>
WebKit Commit Bot
Comment 6 2017-11-22 09:56:16 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-22 09:57:33 PST
<rdar://problem/35668618>
Note You need to log in before you can comment on or make changes to this bug.