Bug 17990
| Summary: | Repeated check in XMLHttpRequest::setRequestHeader | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | carlos pizano <carlos.pizano> |
| Component: | XML | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
carlos pizano
In XMLHttpRequest::setRequestHeader (cpp file)
It appears that
!isValidToken(name) || !isValidHeaderValue(value)
Are performing the same test twice for '\n\r'. In other words isValidToken() is enough until somebody fixes the FIXME in line 131.
Not a big deal.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I'm not sure if I understand this bug - isValidToken and isValidHeaderValue check different variables, how can they be redundant?
carlos pizano
(In reply to comment #1)
> I'm not sure if I understand this bug - isValidToken and isValidHeaderValue
> check different variables, how can they be redundant?
>
You are right. I must need more coffee. Marking as invalid.