Bug 179855

Summary:

REGRESSION (r220646): RenderTreePosition::computeNextSibling hits assertion with certain first-letter mutations

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
test case	none
patch	none

Description Antti Koivisto 2017-11-17 17:43:37 PST

ASSERTION FAILED: skipAssert || nextSiblingRenderer(node) == m_nextSibling
/Users/antti/webkit/OpenSource/Source/WebCore/style/RenderTreePosition.cpp(55) : void WebCore::RenderTreePosition::computeNextSibling(const WebCore::Node &)
1   0x6073a73dd WTFCrash
2   0x5faf770fc WebCore::RenderTreePosition::computeNextSibling(WebCore::Node const&)
3   0x5faf7b5de WebCore::RenderTreeUpdater::createRenderer(WebCore::Element&, WebCore::RenderStyle&&)::$_6::operator()() const
4   0x5faf7a4ed WebCore::RenderTreeUpdater::createRenderer(WebCore::Element&, WebCore::RenderStyle&&)
5   0x5faf79608 WebCore::RenderTreeUpdater::updateElementRenderer(WebCore::Element&, WebCore::Style::ElementUpdate const&)
6   0x5faf78bed WebCore::RenderTreeUpdater::updateRenderTree(WebCore::ContainerNode&)
7   0x5faf784d9 WebCore::RenderTreeUpdater::commit(std::__1::unique_ptr<WebCore::Style::Update const, std::__1::default_delete<WebCore::Style::Update const> >)
8   0x5f9c78ef3 WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType)
9   0x5f9c7a5e1 WebCore::Document::updateStyleIfNeeded()
10  0x5fa4f71fe WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()
11  0x11014cef5 WebKit::WebPage::layoutIfNeeded()

Comment 1 Antti Koivisto 2017-11-17 17:44:36 PST

<rdar://problem/35464071>

Comment 2 Antti Koivisto 2017-11-17 17:45:02 PST

Created attachment 327288 [details]
test case

Comment 3 Antti Koivisto 2017-11-17 17:59:44 PST

Created attachment 327292 [details]
patch

Comment 4 WebKit Commit Bot 2017-11-18 03:46:10 PST

Comment on attachment 327292 [details]
patch

Clearing flags on attachment: 327292

Committed r225014: <https://trac.webkit.org/changeset/225014>

Comment 5 WebKit Commit Bot 2017-11-18 03:46:11 PST

All reviewed patches have been landed.  Closing bug.