FETurbulence: compute all 4 channels at once

• Component: SVG
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

We can compute all 4 channels in one pass.

[Simon Fraser (smfr)]

Created attachment 327203 [details]
Patch

This makes FETurbulence about 2x faster.

[Simon Fraser (smfr)]

Created attachment 327286 [details]
Patch

[Sam Weinig]

Comment on attachment 327286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327286&action=review

> Source/WebCore/platform/graphics/ColorUtilities.h:42
> +    FloatComponents& operator +=(const FloatComponents& rhs)

We don't usually put a space after 'operator'.

> Source/WebCore/platform/graphics/ColorUtilities.h:51
> +    FloatComponents operator +(float rhs) const

We don't usually put a space after 'operator'.

> Source/WebCore/platform/graphics/ColorUtilities.h:61
> +    FloatComponents operator /(float denominator) const

We don't usually put a space after 'operator'.

> Source/WebCore/platform/graphics/ColorUtilities.h:71
> +    FloatComponents operator *(float factor) const

We don't usually put a space after 'operator'.

[Simon Fraser (smfr)]

https://trac.webkit.org/r225009

[Radar WebKit Bug Importer]

<rdar://problem/35628662>

[Sam Weinig]

I know I already reviewed this, but I wonder if this could get an even bigger speedup if we used something like GCC's:

typedef float  float4  __attribute__((__vector_size__(16)))

or clangs:

typedef __attribute__((__ext_vector_type__(4))) float float4;