Bug 17981

Summary: CPPFLAGS are not configured properly in autotools build
Product: WebKit Reporter: Rodney Dawes <dobey>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch to fix cppflags usage in autotools build zecke: review+

Rodney Dawes
Reported 2008-03-21 06:51:41 PDT
Currently the CPPFLAGS configuration for the autotools build causes the JavaScriptCore includes to come before the WebCore includes. When building WebCore, it should find WebCore/config.h before others, which is not currently the case. The attached patch removes the JSCore include path options from global_cppflags, and places them in javascriptcore_cppflags instead, updating the other cppflags variables to use javascriptcore_cppflags when needed.
Attachments
Patch to fix cppflags usage in autotools build (4.40 KB, patch)
2008-03-21 06:52 PDT, Rodney Dawes 		zecke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rodney Dawes
Comment 1 2008-03-21 06:52:11 PDT
Created attachment 19924 [details] Patch to fix cppflags usage in autotools build
Holger Freyther
Comment 2 2008-03-21 11:08:08 PDT
Comment on attachment 19924 [details] Patch to fix cppflags usage in autotools build The addition of WebCore cppflags to the programs in WebKitTools is wrong and should be removed when landing this patch.
Holger Freyther
Comment 3 2008-03-21 11:24:06 PDT
Landed in r31214.
Note You need to log in before you can comment on or make changes to this bug.