Summary: | REGRESSION (r31177): Inspector highlighting of webpage not cleared when going to new URL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Sherlock <gsherloc> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, timothy | ||||
Priority: | P1 | Keywords: | Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Gavin Sherlock
2008-03-20 23:38:34 PDT
I should also note that you can resize the webpage, and the highlighting will stay where it is, even to the point that it can no longer overlap the page that it was originally highlighting. I can't reproduce this in ToT on Windows. Maybe it's a Mac-only issue? I think Tim was seeing something similar. I know what caused this. When the drawing code was moved to WebCore the fade value is ignored in WebNodeHighlightView. We should just remove the fade. Created attachment 19927 [details]
Patch
WebKit/mac/ChangeLog | 28 ++++++++
WebKit/mac/WebCoreSupport/WebInspectorClient.mm | 25 +++-----
WebKit/mac/WebInspector/WebNodeHighlight.h | 14 +---
WebKit/mac/WebInspector/WebNodeHighlight.m | 77 +++--------------------
WebKit/mac/WebInspector/WebNodeHighlightView.h | 8 ---
WebKit/mac/WebInspector/WebNodeHighlightView.m | 28 ++-------
6 files changed, 53 insertions(+), 127 deletions(-)
Comment on attachment 19927 [details]
Patch
11 how just detaches when it is hidden.
Typo: how -> now
r=me
|