Bug 179790

Summary: [WinCairo] Update WinCairoRequirements
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2017-11-16 12:09:51 PST
WinCairoRequirements has been updated https://github.com/WebKitForWindows/WinCairoRequirements/releases/tag/v2017.11.16 and the changes should be reflected in CMake.
Attachments
Patch (4.95 KB, patch)
2017-11-16 15:42 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (4.96 KB, patch)
2017-11-16 15:43 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-11-16 15:42:27 PST
Created attachment 327114 [details] Patch Updates the version numbers to match the contents of WinCairoRequirements and updates the location of cacert.pem within the new directory structure within the zip
Don Olmstead
Comment 2 2017-11-16 15:43:35 PST
Created attachment 327116 [details] Patch
Alex Christensen
Comment 3 2017-11-16 18:11:34 PST
Comment on attachment 327116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327116&action=review > Source/WebCore/PlatformWin.cmake:306 > DESTINATION > ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/WebKit.resources/certificates Can't you specify a destination filename instead of copying then renaming?
Don Olmstead
Comment 4 2017-11-16 19:17:40 PST
(In reply to Alex Christensen from comment #3) > Comment on attachment 327116 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=327116&action=review > > > Source/WebCore/PlatformWin.cmake:306 > > DESTINATION > > ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/WebKit.resources/certificates > > Can't you specify a destination filename instead of copying then renaming? No :( https://cmake.org/cmake/help/v3.10/command/file.html COPY works on a list of files so the destination is a directory and RENAME works on A file.
WebKit Commit Bot
Comment 5 2017-11-16 19:37:02 PST
Comment on attachment 327116 [details] Patch Clearing flags on attachment: 327116 Committed r224959: <https://trac.webkit.org/changeset/224959>
WebKit Commit Bot
Comment 6 2017-11-16 19:37:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-16 19:38:56 PST
<rdar://problem/35607012>
Note You need to log in before you can comment on or make changes to this bug.