Summary: | [WinCairo] Update WinCairoRequirements | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
Component: | Platform | Assignee: | Don Olmstead <don.olmstead> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, pvollan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Don Olmstead
2017-11-16 12:09:51 PST
Created attachment 327114 [details]
Patch
Updates the version numbers to match the contents of WinCairoRequirements and updates the location of cacert.pem within the new directory structure within the zip
Created attachment 327116 [details]
Patch
Comment on attachment 327116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327116&action=review > Source/WebCore/PlatformWin.cmake:306 > DESTINATION > ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/WebKit.resources/certificates Can't you specify a destination filename instead of copying then renaming? (In reply to Alex Christensen from comment #3) > Comment on attachment 327116 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=327116&action=review > > > Source/WebCore/PlatformWin.cmake:306 > > DESTINATION > > ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/WebKit.resources/certificates > > Can't you specify a destination filename instead of copying then renaming? No :( https://cmake.org/cmake/help/v3.10/command/file.html COPY works on a list of files so the destination is a directory and RENAME works on A file. Comment on attachment 327116 [details] Patch Clearing flags on attachment: 327116 Committed r224959: <https://trac.webkit.org/changeset/224959> All reviewed patches have been landed. Closing bug. |