Bug 179790

Summary: [WinCairo] Update WinCairoRequirements
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Don Olmstead 2017-11-16 12:09:51 PST
WinCairoRequirements has been updated https://github.com/WebKitForWindows/WinCairoRequirements/releases/tag/v2017.11.16 and the changes should be reflected in CMake.
Comment 1 Don Olmstead 2017-11-16 15:42:27 PST
Created attachment 327114 [details]
Patch

Updates the version numbers to match the contents of WinCairoRequirements and updates the location of cacert.pem within the new directory structure within the zip
Comment 2 Don Olmstead 2017-11-16 15:43:35 PST
Created attachment 327116 [details]
Patch
Comment 3 Alex Christensen 2017-11-16 18:11:34 PST
Comment on attachment 327116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327116&action=review

> Source/WebCore/PlatformWin.cmake:306
>          DESTINATION
>          ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/WebKit.resources/certificates

Can't you specify a destination filename instead of copying then renaming?
Comment 4 Don Olmstead 2017-11-16 19:17:40 PST
(In reply to Alex Christensen from comment #3)
> Comment on attachment 327116 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327116&action=review
> 
> > Source/WebCore/PlatformWin.cmake:306
> >          DESTINATION
> >          ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/WebKit.resources/certificates
> 
> Can't you specify a destination filename instead of copying then renaming?

No :(

https://cmake.org/cmake/help/v3.10/command/file.html

COPY works on a list of files so the destination is a directory and RENAME works on A file.
Comment 5 WebKit Commit Bot 2017-11-16 19:37:02 PST
Comment on attachment 327116 [details]
Patch

Clearing flags on attachment: 327116

Committed r224959: <https://trac.webkit.org/changeset/224959>
Comment 6 WebKit Commit Bot 2017-11-16 19:37:05 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-16 19:38:56 PST
<rdar://problem/35607012>