Bug 17979

Summary: REGRESSION: Inspector flickers horribly while resizing
Product: WebKit Reporter: Gavin Sherlock <gsherloc>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, dev+webkit, oliver
Priority: P1 Keywords: InRadar, PlatformOnly, Regression
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: http://webkit.org/blog/
Attachments:
Description Flags
Proposed patch none

Description Gavin Sherlock 2008-03-20 23:29:45 PDT 
Steps to reproduce:

1.  Go to http://webkit.org/blog/
2.  Select "background" in the "This background clips to the text." in the black box in the "background-clip: text" story.
3.  Right click, and select Inspect Element
4.  In the inspector window, open scripts, and select the Google analytics script in the side bar (note, no script is shown, not sure if that is a bug, but is the same behavior as in Safari 3.1)
5.  Right click on the urchin.js entry in the side bar, and select Inspect Element
6.  Resize the new Inspector window.

Expected results:  Smooth resizing
Actual Results : Horribly flickering resizing

Regression - Safari 3.1 acts as expected, r31201 shows the bug.
Tested on 10.5.2 on a Dual G5
Comment 1 Gavin Sherlock 2008-03-20 23:32:28 PDT 
Actually affects resize performance of any Inspector window, as far as I can tell - doesn't have to be second one.
Comment 2 Gavin Sherlock 2008-03-22 08:43:52 PDT 
With respect to comment 2, you need to have opened a second Inspector window before the bug will manifest.  After it manifests, the 1st Inspector window you opened will also have the resize problem.  If you close both Inspector windows, then open a new one, the new one does not have the problem.  There are many ways to reproduce this, but the steps in the description work every time.
Comment 3 Adam Roben (:aroben) 2008-04-18 07:09:42 PDT 
*** Bug 18575 has been marked as a duplicate of this bug. ***
Comment 4 Adam Roben (:aroben) 2008-04-18 07:10:45 PDT 
This seems to be Mac-specific.
Comment 5 Adam Roben (:aroben) 2008-04-18 07:14:23 PDT 
<rdar://problem/5873549>
Comment 6 Timothy Hatcher 2008-05-15 12:17:31 PDT 
Created attachment 21172 [details]
Proposed patch
Comment 7 Darin Adler 2008-05-15 12:45:33 PDT 
Comment on attachment 21172 [details]
Proposed patch

r=me
Comment 8 Timothy Hatcher 2008-05-15 13:01:02 PDT 
Landed in r33493.
Comment 9 Gavin Sherlock 2008-07-20 10:55:17 PDT 
This still occurs, though is hard to reproduce.  In my case, I had inspected several pages, and then went to resize the inspector, and it flickered horribly.  This is with r35249 on 10.5.4 on a MacPro.  Curiously, when I opened this bug page to reopen the bug, resizing this page (i.e. a browser page) also flickered horribly.  When I then opened another page, then switched back to this one and resized again, the flickering had gone away.  Thus, there is a complex set of circumstances to get things to flicker, and the flickering can go away again.  If I find a reproducible way to do this, I will post instructions.
Comment 10 Gavin Sherlock 2008-07-20 11:02:35 PDT 
Ok, here's how I can reproduce the flickering of the Inspector:

1.  Launch Webkit (I'm using r35249)
2.  On the "Thank you for Testing Webkit Page", inspect some element, to open up the inspector
3.  Open a new window, so it goes to whatever your default page is (mine is http://genome-www5.stanford.edu/)
4.  Inspect an element on that page, to open a new Inspector window
5.  Click on the first inspector window and resize.

Expected results: smooth resizing

Actual results: horrible flickering

I'm unable thus far to find reproducible conditions to get the browser window to flicker as well during resizing, though have seen it more than once.
Comment 11 mitz 2008-07-25 13:24:29 PDT 
Comment on attachment 21172 [details]
Proposed patch

Removing the review flag since the patch has been landed.
Comment 12 Timothy Hatcher 2008-08-19 15:38:26 PDT 
Landed a fix in r35850.