Bug 179744

Summary: Skip stress/unshiftCountSlowCase-correct-postCapacity.js in memory limited environments
Product: WebKit Reporter: Guillaume Emont <guijemont>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, guijemont, mcatanzaro, msaboff, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Guillaume Emont
Reported 2017-11-15 13:56:49 PST
Skip stress/unshiftCountSlowCase-correct-postCapacity.js on embedded Linux
Attachments
Patch (1.34 KB, patch)
2017-11-15 14:01 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
Patch (1.38 KB, patch)
2017-11-16 09:32 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Guillaume Emont
Comment 1 2017-11-15 13:58:14 PST
It gets OOM-killed on arm and mips.
Guillaume Emont
Comment 2 2017-11-15 14:01:04 PST
Created attachment 327022 [details] Patch
Michael Catanzaro
Comment 3 2017-11-15 19:05:37 PST
Comment on attachment 327022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327022&action=review > JSTests/stress/unshiftCountSlowCase-correct-postCapacity.js:2 > +//@ skip if $memoryLimited && $hostOS == "linux" Not sure why $hostOS is relevant here? Especially since it's already skipped on arm64.
Guillaume Emont
Comment 4 2017-11-16 09:32:38 PST
Created attachment 327070 [details] Patch New version that simplifies things by just skipping whenever we have HEAD~..HEADmemoryLimited
Guillaume Emont
Comment 5 2017-11-20 14:51:16 PST
Ping reviewers.
WebKit Commit Bot
Comment 6 2017-11-20 17:27:06 PST
Comment on attachment 327070 [details] Patch Clearing flags on attachment: 327070 Committed r225061: <https://trac.webkit.org/changeset/225061>
WebKit Commit Bot
Comment 7 2017-11-20 17:27:07 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-11-20 17:28:21 PST
<rdar://problem/35650632>
Note You need to log in before you can comment on or make changes to this bug.