Summary: | Skip stress/unshiftCountSlowCase-correct-postCapacity.js in memory limited environments | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Guillaume Emont <guijemont> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | clopez, commit-queue, guijemont, mcatanzaro, msaboff, webkit-bug-importer, zan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Guillaume Emont
2017-11-15 13:56:49 PST
It gets OOM-killed on arm and mips. Created attachment 327022 [details]
Patch
Comment on attachment 327022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327022&action=review > JSTests/stress/unshiftCountSlowCase-correct-postCapacity.js:2 > +//@ skip if $memoryLimited && $hostOS == "linux" Not sure why $hostOS is relevant here? Especially since it's already skipped on arm64. Created attachment 327070 [details]
Patch
New version that simplifies things by just skipping whenever we have HEAD~..HEADmemoryLimited
Ping reviewers. Comment on attachment 327070 [details] Patch Clearing flags on attachment: 327070 Committed r225061: <https://trac.webkit.org/changeset/225061> All reviewed patches have been landed. Closing bug. |