Bug 179723

Summary: [GTK] accessibility/accessibility-object-model.html fails
Product: WebKit Reporter: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, bugs-noreply, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, n_wang, samuel_white
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179494
Attachments:
Description Flags
patch none

Description Ms2ger (he/him; ⌚ UTC+1/+2) 2017-11-15 03:51:26 PST
Since it was added in r224871.

Looks like some labels are missing.

--- /accessibility/accessibility-object-model-expected.txt
+++ /accessibility/accessibility-object-model-actual.txt
@@ -13,7 +13,7 @@
 
 ARIA attributes should not be reflected into AOM properties.
 PASS axButton.role is 'AXRole: AXCheckBox'
-PASS axButton.description is 'AXDescription: label'
+FAIL axButton.description should be AXDescription: label. Was AXDescription: .
 PASS button.accessibleNode.role is null
 PASS button.accessibleNode.label is null
 
@@ -21,7 +21,7 @@
 PASS button.accessibleNode.role is 'slider'
 PASS button.accessibleNode.label is 'AOM Label'
 PASS axButton.role is 'AXRole: AXSlider'
-PASS axButton.description is 'AXDescription: AOM Label'
+FAIL axButton.description should be AXDescription: AOM Label. Was AXDescription: .
 
 Setting some of the AOM properties should be able to make an element accessible.
 PASS axParagraph == null || axParagraph == undefined is true
Comment 1 chris fleizach 2017-11-15 11:13:31 PST
Joanie can we enable AOM for GTK?
Comment 2 Nan Wang 2017-11-15 11:19:23 PST
I think AOM is enabled in the tests, since the role is working correctly. I think on GTK it's not using axobject.description as the label.
Comment 3 Nan Wang 2017-11-15 11:31:14 PST
Created attachment 327002 [details]
patch
Comment 4 WebKit Commit Bot 2017-11-15 12:02:08 PST
Comment on attachment 327002 [details]
patch

Clearing flags on attachment: 327002

Committed r224893: <https://trac.webkit.org/changeset/224893>
Comment 5 WebKit Commit Bot 2017-11-15 12:02:09 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Joanmarie Diggs 2017-11-15 12:43:49 PST
Nan I see you found the cross-platform-friend utilities. Thanks for updating your tests so quickly!! :)