Bug 179686

Summary:

[Service Workers] Mark ServiceWorkerContainer / ServiceWorkerRegistration / Clients as ActiveDOMObjects in the IDL

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, buildbot, esprehn+autocc, ggaren, kondapallykalyan, sam, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2017-11-14 12:42:54 PST

[Service Workers] Mark ServiceWorkerContainer / ServiceWorkerRegistration / Clients as ActiveDOMObjects in the IDL, since they are ActiveDOMObjects. This is needed for proper garbage collection.

Attachments
Patch (2.55 KB, patch) 2017-11-14 12:43 PST, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-11-14 12:43:48 PST

Created attachment 326909 [details] Patch

Sam Weinig

Comment 2 2017-11-14 12:50:13 PST

Comment on attachment 326909 [details] Patch Can this be tested?

Chris Dumez

Comment 3 2017-11-14 12:51:49 PST

(In reply to Sam Weinig from comment #2) > Comment on attachment 326909 [details] > Patch > > Can this be tested? Do you know how? I guess I can try calling one of the methods that returns a Promise and takes a PendingActivity, trigger a gc() that would in theory gc the wrapper.

Sam Weinig

Comment 4 2017-11-14 13:10:05 PST

(In reply to Chris Dumez from comment #3) > (In reply to Sam Weinig from comment #2) > > Comment on attachment 326909 [details] > > Patch > > > > Can this be tested? > > Do you know how? I guess I can try calling one of the methods that returns a > Promise and takes a PendingActivity, trigger a gc() that would in theory gc > the wrapper. Sounds about right.

Chris Dumez

Comment 5 2017-11-15 16:10:56 PST

Will address separately, in other patches.

Note You need to log in before you can comment on or make changes to this bug.