Bug 179676

Summary:

Make whitespace text renderer decisions simper and more consistent

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

bfulgham, buildbot, rniwa, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none

Antti Koivisto

Reported 2017-11-14 10:57:07 PST

Always ignore out-of-flow renderers.

Attachments
patch (3.53 KB, patch) 2017-11-14 10:59 PST, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (592.89 KB, application/zip) 2017-11-14 11:35 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (424.82 KB, application/zip) 2017-11-14 11:45 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (468.31 KB, application/zip) 2017-11-14 11:59 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (504.63 KB, application/zip) 2017-11-14 14:01 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-11-14 10:59:56 PST

Created attachment 326892 [details] patch

Build Bot

Comment 2 2017-11-14 11:03:00 PST

Attachment 326892 [details] did not pass style-queue: ERROR: Source/WebCore/style/RenderTreeUpdater.cpp:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/style/RenderTreeUpdater.cpp:428: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/style/RenderTreeUpdater.cpp:430: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/style/RenderTreeUpdater.cpp:431: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2017-11-14 11:35:33 PST

Comment on attachment 326892 [details] patch Attachment 326892 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5231041 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2017-11-14 11:35:34 PST

Created attachment 326898 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-11-14 11:45:37 PST

Comment on attachment 326892 [details] patch Attachment 326892 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5231250 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2017-11-14 11:45:38 PST

Created attachment 326900 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-11-14 11:59:06 PST

Comment on attachment 326892 [details] patch Attachment 326892 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5231217 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2017-11-14 11:59:07 PST

Created attachment 326905 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-11-14 14:01:17 PST

Comment on attachment 326892 [details] patch Attachment 326892 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5232822 Number of test failures exceeded the failure limit.

Build Bot

Comment 10 2017-11-14 14:01:19 PST

Created attachment 326922 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Note You need to log in before you can comment on or make changes to this bug.