Summary: | image ALT text not shown when image loading is disabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alan Jenkins <alan-jenkins> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | CC: | webkit | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Alan Jenkins
2008-03-20 07:00:18 PDT
Created attachment 19897 [details]
Test case
Here's an example of an image with ALT text.
Note that if you try this in Firefox you need to access it via http. If you use file:// then the image will load even if you disable image loading.
Created attachment 19898 [details]
Proposed fix
Regression tests aren't running under linux :-(. I've tried to follow the rest of the code submission guidelines though.
Build and run-tested, on linux Qt and Gtk. Does more or less what it's supposed to. It's not ideal - Firefox has a better solution, where it almost looks like the ALT text is made into a text node and completely replaces the image. In particular, the ALT text for inline images will not have the same baseline as the surrounding text. It's much better than doing nothing though.
Comment on attachment 19898 [details]
Proposed fix
You didn't mean to turn off image autoloading in the QTLauncher did you?
This patch will need to be updated to reflect the changes that made generated content wrap the cached image... you might need a virtual stillNeedsLoad method on RenderImage (similar to errorOccurred).
|