Summary: | REGRESSION(r224799): WebKit crashes at launch on macOS Sierra due to a sandbox violation | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bfulgham, dewei_zhu, ryanhaddad, simon.fraser, webkit-bug-importer, zalan |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 179548 | ||
Bug Blocks: |
Description
Ryosuke Niwa
2017-11-13 21:40:20 PST
Actually, I'm hitting the following sandbox violation: com.apple.WebKit.WebContent.Development: Couldn't initialize sandbox profile [/Volumes/Data/webkit2/WebKitBuild/Debug/WebKit.framework/Resources/com.apple.WebProcess.sb], error '/Volumes/Data/webkit2/WebKitBuild/Debug/WebKit.framework/Resources/com.apple.WebProcess.sb:40:21: unbound variable: xpc-service-name-prefix ' This crash only reproduces on Sierra, not High Sierra. Ryosuke, can you roll back (or fix) now? Better to not have a broken WebKit overnight. Committed r224805: <https://trac.webkit.org/changeset/224805> (In reply to Ryosuke Niwa from comment #4) > Committed r224805: <https://trac.webkit.org/changeset/224805> Temporarily reverted the sandbox change in macOS Sierra as follows: Index: /trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in =================================================================== --- /trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (revision 224804) +++ /trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (revision 224805) @@ -26,5 +26,5 @@ (allow system-audit file-read-metadata) -#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101200 +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101200 (import "system.sb") #else Please either come up with a proper fix or close the bug based on what you want. (In reply to Ryosuke Niwa from comment #5) > (In reply to Ryosuke Niwa from comment #4) > > Committed r224805: <https://trac.webkit.org/changeset/224805> > > Temporarily reverted the sandbox change in macOS Sierra as follows: > > Index: /trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in > =================================================================== > --- /trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (revision > 224804) > +++ /trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (revision > 224805) > @@ -26,5 +26,5 @@ > (allow system-audit file-read-metadata) > > -#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101200 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101200 > (import "system.sb") > #else > > > Please either come up with a proper fix or close the bug based on what you > want. This change is correct -- I should have used <= in the comparison, as we don't want to change behavior pre-High Sierra. Sorry for the inconvenience, and thank you for fixing this. I think we need to fix the condition per Dan's comment. Committed r224816: <https://trac.webkit.org/changeset/224816> |