| Summary: | Give a ServiceWorker WebContentProcess a different display name | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
| Component: | WebKit Misc. | Assignee: | Joseph Pecoraro <joepeck> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aestes, beidson, buildbot, cdumez, commit-queue, ggaren, joepeck, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Joseph Pecoraro
2017-11-13 20:22:02 PST
Created attachment 326845 [details]
[PATCH] Proposed Fix
definitely good to have! Attachment 326845 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.h:36: The parameter name "pool" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.h:36: The parameter name "store" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 326845 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=326845&action=review > Source/WebKit/UIProcess/ServiceWorkerProcessProxy.h:36 > + static Ref<ServiceWorkerProcessProxy> create(WebProcessPool& pool, WebsiteDataStore& store); Obey stylebot Created attachment 326861 [details]
[PATCH] For Landing
Comment on attachment 326861 [details] [PATCH] For Landing Clearing flags on attachment: 326861 Committed r224806: <https://trac.webkit.org/changeset/224806> |