Bug 179647

Summary: Pass --useDollarVM=true to all JSC tests.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 179684    
Bug Blocks:    
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2017-11-13 17:39:57 PST
This is in preparation for moving unsafe jsc shell functions to $vm.
Attachments
proposed patch. (1.71 KB, patch)
2017-11-13 17:41 PST, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-11-13 17:41:50 PST
Created attachment 326833 [details] proposed patch.
Mark Lam
Comment 2 2017-11-13 19:00:42 PST
Thanks for the review. Landed in r224800: <http://trac.webkit.org/r224800>.
WebKit Commit Bot
Comment 3 2017-11-14 12:20:56 PST
Re-opened since this is blocked by bug 179684
Mark Lam
Comment 4 2017-11-22 10:05:33 PST
It turns out that there's a bug in the Cloop build that can result in some stack values being wrongly nullified by the stack sanitizer (see https://bugs.webkit.org/show_bug.cgi?id=179936). This bug was triggered because the addition of the $vm object bumped allocation sufficiently such that a slow path allocation is triggered at just the right moment, which in turn, ran the stack sanitizer and manifested the bug. Incidentally, Saam added some properties to $vm (in r224938). This perturbed the allocation pattern sufficiently such that the CLoop stack sanitizer bug is now hidden again. Since the bug isn't due to this patch to add the --useDollarVM=true option, and the effects of the bug has been masked in ToT (due to r224938), I'll re-land this patch.
Mark Lam
Comment 5 2017-11-22 10:09:27 PST
Re-landed in r225097: <http://trac.webkit.org/r225097>.
Radar WebKit Bug Importer
Comment 6 2017-11-22 10:11:01 PST
<rdar://problem/35668712>
Note You need to log in before you can comment on or make changes to this bug.