| Summary: | Web Inspector: refactor active WebSocket tracking to not use raw pointers | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||
| Status: | NEW --- | ||||||||||||||
| Severity: | Normal | CC: | achristensen, buildbot, hi, inspector-bugzilla-changes, timothy | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Devin Rousso
2017-11-13 13:32:42 PST
Created attachment 326792 [details]
Patch
Comment on attachment 326792 [details] Patch Attachment 326792 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5215550 Number of test failures exceeded the failure limit. Created attachment 326801 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 326792 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326792&action=review > Source/WebCore/Modules/websockets/WebSocket.cpp:182 > +HashSet<Ref<WebSocket>>& WebSocket::allActiveWebSockets(const LockHolder&) WebSockets are added in their constructor and removed in their destructor. This will make it so they are added in their constructor and never deleted because their destructor will never be called because there will always be at least one ref. Created attachment 365452 [details]
Patch
Created attachment 365462 [details]
Patch
Created attachment 365468 [details]
Patch
Comment on attachment 365468 [details]
Patch
Build fails.
|