Bug 179566

Summary:

[Service Workers] Registration promise should be rejected when the service worker fails to start

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, buildbot, commit-queue, ggaren, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none

Chris Dumez

Reported 2017-11-10 16:54:45 PST

Registration promise should be rejected when the service worker fails to start.

Attachments
WIP Patch (25.33 KB, patch) 2017-11-10 18:21 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (29.38 KB, patch) 2017-11-10 18:35 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.53 MB, application/zip) 2017-11-10 19:44 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.12 MB, application/zip) 2017-11-10 19:58 PST, Build Bot	no flags	Details
Patch (30.63 KB, patch) 2017-11-10 20:13 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-11-10 18:21:02 PST

Created attachment 326669 [details] WIP Patch

Chris Dumez

Comment 2 2017-11-10 18:35:24 PST

Created attachment 326671 [details] Patch

Build Bot

Comment 3 2017-11-10 19:44:57 PST

Comment on attachment 326671 [details] Patch Attachment 326671 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5186001 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html

Build Bot

Comment 4 2017-11-10 19:44:58 PST

Created attachment 326673 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-11-10 19:57:58 PST

Comment on attachment 326671 [details] Patch Attachment 326671 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5186015 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html

Build Bot

Comment 6 2017-11-10 19:58:00 PST

Created attachment 326674 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 7 2017-11-10 20:13:15 PST

Created attachment 326675 [details] Patch

Brady Eidson

Comment 8 2017-11-10 20:34:00 PST

Comment on attachment 326675 [details] Patch NICE

WebKit Commit Bot

Comment 9 2017-11-10 21:15:19 PST

Comment on attachment 326675 [details] Patch Clearing flags on attachment: 326675 Committed r224723: <https://trac.webkit.org/changeset/224723>

WebKit Commit Bot

Comment 10 2017-11-10 21:15:21 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2017-11-15 09:34:53 PST

<rdar://problem/35562001>

Note You need to log in before you can comment on or make changes to this bug.