Summary: | Bug to test EWS with non-unicode characters | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | aakash_jain, ews-feeder, ews-watchlist | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Version: | Other | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Aakash Jain
2017-11-10 08:16:55 PST
Created attachment 326588 [details]
Proposed patch
Patch with webkitpy test failure.
Created attachment 328314 [details]
Patch with webkitpy test failure.
Created attachment 328315 [details]
Patch with webkitpy test failure.
Created attachment 365336 [details]
Patch with API test failure
Created attachment 367626 [details]
Proposed patch
Created attachment 367629 [details]
Proposed patch
Created attachment 367700 [details]
Proposed patch
Created attachment 368027 [details]
Proposed patch
Created attachment 368044 [details]
Proposed patch
Created attachment 368161 [details]
Proposed patch
Attachment 368161 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/CheckedArithmetic.h:395: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:463: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:471: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1002: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1040: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1060: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WTF/wtf/CheckedArithmetic.h:1123: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 7 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368166 [details]
Proposed patch
Created attachment 368182 [details]
Proposed patch
Created attachment 368258 [details]
Proposed patch
Created attachment 368561 [details]
Proposed patch
Created attachment 368562 [details]
Proposed patch
Created attachment 368581 [details]
Proposed patch
Created attachment 368582 [details]
Proposed patch
Created attachment 368799 [details]
Patch
Created attachment 368800 [details]
Patch
Created attachment 368803 [details]
Patch
Created attachment 368834 [details]
Patch
Created attachment 369071 [details]
Patch
Created attachment 372636 [details]
Patch
Created attachment 373191 [details]
Patch
Created attachment 374577 [details]
patch
Created attachment 374579 [details]
Patch with buildbot checkconfig failure
Created attachment 374580 [details]
Patch with buildbot checkconfig failure
Created attachment 374609 [details]
Patch with buildbot checkconfig failure
Created attachment 374826 [details]
Patch
Created attachment 377091 [details]
Patch
Created attachment 377155 [details]
Patch
Created attachment 380828 [details]
Patch
Created attachment 387729 [details]
Patch
Tools/Scripts/svn-apply failed to apply attachment 395068 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 402557 [details]
test-jsc-patch
ChangeLog entry in Tools/ChangeLog contains OOPS!. Created attachment 404379 [details]
Patch
Reopening for testing. Created attachment 406185 [details]
Patch
Created attachment 406192 [details]
Patch
Created attachment 406799 [details]
Clean-build-Patch
Created attachment 425394 [details]
[fast-cq] Patch
Created attachment 425408 [details]
[fast-cq] Patch
Created attachment 427272 [details]
Patch
Created attachment 427279 [details]
Patch
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. |