Bug 179530

Summary: fix style failures in webkitpy: multiple statements on one line (semicolon)
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, ap, buildbot, commit-queue, dbates, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=179529
Attachments:
Description Flags
Proposed patch
none
Archive of layout-test-results from ews114 for mac-elcapitan none

Aakash Jain
Reported 2017-11-10 08:12:46 PST
Running check-webkit-style on webkitpy results in various failures of type: "multiple statements on one line (semicolon)". We should fix these to make sure webkitpy is following the style guidelines.
Attachments
Proposed patch (3.14 KB, patch)
2017-11-10 08:15 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews114 for mac-elcapitan (2.89 MB, application/zip)
2017-11-10 09:40 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-11-10 08:15:17 PST
Created attachment 326586 [details] Proposed patch
Build Bot
Comment 2 2017-11-10 09:40:28 PST
Comment on attachment 326586 [details] Proposed patch Attachment 326586 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5177863 New failing tests: fast/block/positioning/fixed-container-with-relative-parent.html
Build Bot
Comment 3 2017-11-10 09:40:29 PST
Created attachment 326596 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 4 2017-11-10 09:46:25 PST
Comment on attachment 326586 [details] Proposed patch Clearing flags on attachment: 326586 Committed r224691: <https://trac.webkit.org/changeset/224691>
WebKit Commit Bot
Comment 5 2017-11-10 09:46:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 09:37:33 PST
<rdar://problem/35562088>
Note You need to log in before you can comment on or make changes to this bug.