Summary: | The memory consumption of DFG::BasicBlock can be easily reduced a bit | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||||
Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Minor | CC: | buildbot, commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Robin Morisset
2017-11-10 07:43:06 PST
Created attachment 326581 [details]
Patch
Attachment 326581 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGBasicBlock.cpp:39: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGBasicBlock.cpp:40: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGBasicBlock.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGBasicBlock.cpp:46: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGBasicBlock.cpp:47: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGBasicBlock.cpp:48: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 6 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 326581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326581&action=review r=me > Source/JavaScriptCore/bytecode/Operands.h:186 > { You can just write this as: operand(operand) = value > Source/JavaScriptCore/bytecode/Operands.h:252 > + size_t m_numArguments; I say make this unsigned. This probably won’t matter because of padding, but it might be useful if someone adds a field in the future. Created attachment 326589 [details]
Patch for landing
Comment on attachment 326589 [details] Patch for landing Rejecting attachment 326589 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: es/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/UnifiedSource28.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/UnifiedSource9.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource9.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/5177748 Created attachment 326592 [details]
Patch for landing
Comment on attachment 326592 [details] Patch for landing Clearing flags on attachment: 326592 Committed r224689: <https://trac.webkit.org/changeset/224689> All reviewed patches have been landed. Closing bug. |