Summary: | check-webkit-style: AttributeError: 'NoneType' object has no attribute 'major' | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, buildbot, commit-queue, glenn, jbedard, lforschler, ryanhaddad, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=179534 | ||||||
Attachments: |
|
Description
Fujii Hironori
2017-11-09 22:28:02 PST
Created attachment 326558 [details]
Patch
I suspect this is on a machine without an iOS SDK installed, correct? Comment on attachment 326558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326558&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:118 > + return Version(self.host.platform.xcode_sdk_version('iphonesimulator')) This might pass None to Version(). We should have a log statement at https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/version.py#L44 That can be done either in this patch or separate patch. (In reply to Aakash Jain from comment #3) > Comment on attachment 326558 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326558&action=review > > > Tools/Scripts/webkitpy/port/ios_simulator.py:118 > > + return Version(self.host.platform.xcode_sdk_version('iphonesimulator')) > > This might pass None to Version(). We should have a log statement at > https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/ > version.py#L44 > > That can be done either in this patch or separate patch. I am of the opinion this should be done in another patch. This is also a side-effect of a long-standing issue which I've just filed a bug for <https://bugs.webkit.org/show_bug.cgi?id=179534>. Maybe just a FIXME and ultimately, we address the root cause? I'm going to land this patch so that our trees don't spend the weekend red. Comment on attachment 326558 [details] Patch Clearing flags on attachment: 326558 Committed r224722: <https://trac.webkit.org/changeset/224722> All reviewed patches have been landed. Closing bug. |