Bug 179517

Summary: ServiceWorkerRegistration objects may get recycled for different SWServerRegistration objects
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, ggaren, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-11-09 18:41:08 PST
ServiceWorkerRegistration objects may get recycled for different SWServerRegistration objects, leading to flakiness in the tests. Right now, we use ServiceWorkerRegistrationKey as key in the m_registration map on WebProcess side. The lifetime of the ServiceWorkerRegistration objects is tied to the lifetime of their JS wrapper. When the test does a registration for a given scope, then unregisters, then registers again for the same scope, we end up creating a new SWServerRegistration object on server side, but possibly reuse the same ServiceWorkerRegistration object on WebProcess side, if the wrapper has not been garbage collected. This is because the registrations have the same ServiceWorkerRegistrationKey.
Attachments
Patch (81.22 KB, patch)
2017-11-09 20:03 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (51.78 KB, patch)
2017-11-09 22:04 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (51.59 KB, patch)
2017-11-09 22:24 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-09 20:03:01 PST
Created attachment 326538 [details] Patch
Chris Dumez
Comment 2 2017-11-09 22:04:46 PST
Created attachment 326553 [details] Patch
Brady Eidson
Comment 3 2017-11-09 22:14:33 PST
Comment on attachment 326553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326553&action=review > Source/WebCore/ChangeLog:22 > + * WebCore.xcodeproj/project.pbxproj: This is no longer changed \o/
Chris Dumez
Comment 4 2017-11-09 22:24:36 PST
Created attachment 326555 [details] Patch
Chris Dumez
Comment 5 2017-11-09 22:26:45 PST
Comment on attachment 326555 [details] Patch Clearing flags on attachment: 326555 Committed r224664: <https://trac.webkit.org/changeset/224664>
Chris Dumez
Comment 6 2017-11-09 22:26:47 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 09:43:24 PST
<rdar://problem/35562308>
Note You need to log in before you can comment on or make changes to this bug.