Bug 179516

Summary:

[CG] PDF document cached image is regenerated every time the destination rectangle changes

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

PDF

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, mitz, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Apple.pdf	none
test case	none
Patch	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none

Said Abou-Hallawa

Reported 2017-11-09 18:08:01 PST

Open the attached test case. The image movement is not smooth as it should be. The reason for this choppy animation is the PDF is drawn into a cached ImageBuffer every time it moves. Since the whole image is cached when it is drawn for the first time. It should not recached when the destination rectangle changes.

Attachments
Apple.pdf (758.64 KB, application/pdf) 2017-11-09 18:08 PST, Said Abou-Hallawa	no flags	Details
test case (513 bytes, text/html) 2017-11-09 18:09 PST, Said Abou-Hallawa	no flags	Details
Patch (3.52 KB, patch) 2017-11-09 18:54 PST, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.15 MB, application/zip) 2017-11-09 20:16 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Said Abou-Hallawa

Comment 1 2017-11-09 18:08:21 PST

Created attachment 326524 [details] Apple.pdf

Said Abou-Hallawa

Comment 2 2017-11-09 18:09:47 PST

Created attachment 326525 [details] test case

Said Abou-Hallawa

Comment 3 2017-11-09 18:10:38 PST

<rdar://problem/34791461>

Said Abou-Hallawa

Comment 4 2017-11-09 18:54:02 PST

Created attachment 326530 [details] Patch

Build Bot

Comment 5 2017-11-09 20:16:27 PST

Comment on attachment 326530 [details] Patch Attachment 326530 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5172646 New failing tests: http/tests/workers/service/service-worker-clear.html

Build Bot

Comment 6 2017-11-09 20:16:28 PST

Created attachment 326540 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 7 2017-11-10 17:43:40 PST

Comment on attachment 326530 [details] Patch Clearing flags on attachment: 326530 Committed r224719: <https://trac.webkit.org/changeset/224719>

WebKit Commit Bot

Comment 8 2017-11-10 17:43:41 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.