Bug 179516

Summary: [CG] PDF document cached image is regenerated every time the destination rectangle changes
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: PDFAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, mitz, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Apple.pdf
none
test case
none
Patch
none
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Description Said Abou-Hallawa 2017-11-09 18:08:01 PST 
Open the attached test case. The image movement is not smooth as it should be.

The reason for this choppy animation is the PDF is drawn into a cached ImageBuffer every time it moves. Since the whole image is cached when it is drawn for the first time. It should not recached when the destination rectangle changes.
Comment 1 Said Abou-Hallawa 2017-11-09 18:08:21 PST 
Created attachment 326524 [details]
Apple.pdf
Comment 2 Said Abou-Hallawa 2017-11-09 18:09:47 PST 
Created attachment 326525 [details]
test case
Comment 3 Said Abou-Hallawa 2017-11-09 18:10:38 PST 
<rdar://problem/34791461>
Comment 4 Said Abou-Hallawa 2017-11-09 18:54:02 PST 
Created attachment 326530 [details]
Patch
Comment 5 Build Bot 2017-11-09 20:16:27 PST 
Comment on attachment 326530 [details]
Patch

Attachment 326530 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5172646

New failing tests:
http/tests/workers/service/service-worker-clear.html
Comment 6 Build Bot 2017-11-09 20:16:28 PST 
Created attachment 326540 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 7 WebKit Commit Bot 2017-11-10 17:43:40 PST 
Comment on attachment 326530 [details]
Patch

Clearing flags on attachment: 326530

Committed r224719: <https://trac.webkit.org/changeset/224719>
Comment 8 WebKit Commit Bot 2017-11-10 17:43:41 PST 
All reviewed patches have been landed.  Closing bug.