| Summary: | Fix a few FIXMEs in WebFrameIOS | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aestes, buildbot, commit-queue, darin, rniwa, simon.fraser, thorton, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Megan Gardner
2017-11-09 16:02:31 PST
Created attachment 326503 [details]
Patch
Comment on attachment 326503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326503&action=review > Source/WebKitLegacy/ios/ChangeLog:9 > + I don't see that it's used anywhere, but no reason to leave things cluttered. This does not seem like good rationale. If this method is definitely not used or this value is definitely not used, then it’s fine to change the code. If it is used, then we should not change it unless we’ve tested what effect the change has. You wrote a comment here “I don’t see that it's used” but I can’t figure out whether that means we are sure this change will have no effect. But to state the obvious, the behavior of the software is more important than the messiness of a FIXME comment. Created attachment 326630 [details]
Patch
Comment on attachment 326630 [details] Patch Attachment 326630 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5182542 New failing tests: webarchive/adopt-inline-styled-node-webarchive.html Created attachment 326636 [details]
Archive of layout-test-results from ews102 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 326630 [details] Patch Attachment 326630 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5183702 New failing tests: http/wpt/web-animations/timing-model/animations/updating-the-finished-state.html Created attachment 326658 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
This is literally only touching iOS code, these test cannot be broken due to this change. Comment on attachment 326630 [details] Patch Clearing flags on attachment: 326630 Committed r224734: <https://trac.webkit.org/changeset/224734> All reviewed patches have been landed. Closing bug. |