Bug 179508

Summary: [WinCairo] Cannot find ImageDiff executable
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: Tools / TestsAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Basuke.Suzuki, bfulgham, buildbot, commit-queue, don.olmstead, glenn, lforschler, pvollan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 179216    
Attachments:
Description Flags
patch
pvollan: review+
fix
none
fix reviewer none

Description Basuke Suzuki 2017-11-09 15:17:07 PST 
Without Cygwin, it cannot find ImageDiff executable.
Comment 1 Basuke Suzuki 2017-11-09 15:30:17 PST 
Created attachment 326495 [details]
patch
Comment 2 Per Arne Vollan 2017-11-09 15:56:59 PST 
Comment on attachment 326495 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326495&action=review

R=me.

> Tools/Scripts/webkitpy/port/win.py:165
> +        """Return current platform is Cygwin or not"""

Perhaps change this to "Return whether current platform is Cygwin or not".
Comment 3 Basuke Suzuki 2017-11-09 16:09:13 PST 
Created attachment 326501 [details]
fix
Comment 4 Basuke Suzuki 2017-11-09 16:11:39 PST 
Created attachment 326504 [details]
fix reviewer
Comment 5 WebKit Commit Bot 2017-11-09 16:48:54 PST 
Comment on attachment 326504 [details]
fix reviewer

Clearing flags on attachment: 326504

Committed r224656: <https://trac.webkit.org/changeset/224656>
Comment 6 WebKit Commit Bot 2017-11-09 16:48:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 09:43:35 PST 
<rdar://problem/35562313>