| Summary: | [WinCairo] Add network (curl) files for wincairo webkit | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yousuke Kimoto <Yousuke.Kimoto> | ||||||||||||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, buildbot, commit-queue, don.olmstead, ews-watchlist, pvollan, rniwa, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||
| Bug Blocks: | 174003 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Yousuke Kimoto
2017-11-09 04:54:42 PST
Created attachment 326853 [details]
[PATCH] Add network (curl) files for WinCairo WebKit
Comment on attachment 326853 [details] [PATCH] Add network (curl) files for WinCairo WebKit Attachment 326853 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5224256 New failing tests: http/tests/workers/service/service-worker-clear.html Created attachment 326862 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
WinCairo EWS is failing because of r224791 but other than that it should be okay to review. Not sure what's up with ios-sim as this patch has no ios modifications. Comment on attachment 326853 [details] [PATCH] Add network (curl) files for WinCairo WebKit View in context: https://bugs.webkit.org/attachment.cgi?id=326853&action=review > Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:69 > +void NetworkStorageSession::ensurePrivateBrowsingSession(PAL::SessionID sessionID, const String&) This will need rebasing after https://trac.webkit.org/changeset/224791/webkit Created attachment 326929 [details]
Rebased
Rebasing patch
Created attachment 326931 [details]
Rebased
(In reply to Alex Christensen from comment #5) > Comment on attachment 326853 [details] > [PATCH] Add network (curl) files for WinCairo WebKit > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326853&action=review > > > Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:69 > > +void NetworkStorageSession::ensurePrivateBrowsingSession(PAL::SessionID sessionID, const String&) > > This will need rebasing after https://trac.webkit.org/changeset/224791/webkit ensurePrivateBrowsingSession() must be removed from attachment 326853 [details], I'll do that. Created attachment 327141 [details]
[PATCH] Add network (curl) files for wincairo webkit
Comment on attachment 327141 [details] [PATCH] Add network (curl) files for wincairo webkit Attachment 327141 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5267705 New failing tests: http/tests/appcache/offline-access.html Created attachment 327144 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 327145 [details]
[PATCH] Add network (curl) files for wincairo webkit
Just updated reviewer's line.
Comment on attachment 327145 [details] [PATCH] Add network (curl) files for wincairo webkit Clearing flags on attachment: 327145 Committed r224961: <https://trac.webkit.org/changeset/224961> All reviewed patches have been landed. Closing bug. |